Skip to content

fix(yaml): byte[] serialization #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2025
Merged

fix(yaml): byte[] serialization #1657

merged 4 commits into from
Sep 5, 2025
+53 −23

Conversation

IvanJosipovic
Copy link
Contributor

@IvanJosipovic IvanJosipovic commented Sep 3, 2025 •
edited
Loading

Fixes #1650

Yaml serialization now converts bytes[] to a Base64 encoded string like kubectl.

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2025
@IvanJosipovic IvanJosipovic mentioned this pull request Sep 3, 2025
Closed
@tg123
Copy link
Member

tg123 commented Sep 4, 2025

i wonder if this will break configmap?

@IvanJosipovic
Copy link
Contributor Author

This PR makes Yaml Import/Export behave just like Kubectl.

I applied the following ConfigMap:

apiVersion: v1
binaryData:
  username: YlhrdFlYQnc=
data:
  password: Mzk1MjgkdmRnN0pi
kind: ConfigMap
metadata:
  name: test-configmap

Working as expected:
image

@tg123
Copy link
Member

tg123 commented Sep 5, 2025

thanks for confirming, could you please also add testcase to cover configmap?

tg123
tg123 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IvanJosipovic, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 885b9ae into kubernetes-client:master Sep 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KubernetesYaml.Serialize() producing invalid Secret data by converting byte[] to plain strings
3 participants
@IvanJosipovic @tg123 @k8s-ci-robot